Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.spacy: fix build #60276

Merged
merged 1 commit into from Apr 26, 2019
Merged

python3Packages.spacy: fix build #60276

merged 1 commit into from Apr 26, 2019

Conversation

danieldk
Copy link
Contributor

spaCy 2.0.18 requires an older version of wheel. Remove upper bound.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
python3Packages.spacy: fix build
e8cc0db 
spaCy 2.0.18 requires an older version of wheel. Remove upper bound.
@danieldk danieldk requested a review from FRidh as a code owner April 26, 2019 17:39
@danieldk
Copy link
Contributor Author

There's also a new major release of spaCy (2.1.0), but this requires bigger changes, including new models. So this is a small change to make the current version work again.

@danieldk
Copy link
Contributor Author

@GrahamcOfBorg build python36Packages.spacy python37Packages.spacy

@dotlambda dotlambda merged commit 58c4739 into NixOS:master Apr 26, 2019
@danieldk danieldk deleted the spacy-build branch May 2, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @dotlambda