Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ckb-next service: apply udev rules provided by package #60263

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ckb-next service: apply udev rules provided by package #60263

wants to merge 1 commit into from

Conversation

kierdavis
Copy link
Contributor

@kierdavis kierdavis commented Apr 26, 2019 •
edited

Motivation for this change

The package provides these udev rules with the presumption that OS maintainers will install and use them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) - increase by 0.21%
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kierdavis
Copy link
Contributor Author

kierdavis commented May 9, 2019 •
edited

Tested that this compiles and boots without error, and successfully detects my Corsair keyboard (Strafe) and mouse (Sabre RGB).

Additionally I can confirm that symlinks in /dev/input/by-id were created by the inclusion of this udev rule, which do not exist without this change having been made.

This is now ready for review.

@kierdavis kierdavis marked this pull request as ready for review May 9, 2019 21:43
@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 17, 2020
@kierdavis
Copy link
Contributor Author

(triage) I've tested this PR. Please could the code change be approved and merged?

@ryantm
Copy link
Member

ryantm commented Jun 29, 2020

@GrahamcOfBorg eval

@ryantm
Copy link
Member

ryantm commented Jun 29, 2020

@GrahamcOfBorg build ckb-next

ryantm
ryantm requested changes Jun 29, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR breaks the build of ckb-next. Probably the postPatch needs to be tweaked.

@stale
Copy link

stale bot commented Jan 2, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 18, 2021
@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@wegank wegank marked this pull request as draft March 20, 2024 15:01
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kierdavis @ryantm @SuperSandro2000 @wegank