Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix orca and re-add liblouis #60175

Merged
merged 2 commits into from Apr 25, 2019
Merged

Fix orca and re-add liblouis #60175

merged 2 commits into from Apr 25, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

Orca was broken because of the gobject-introspection issue (56943). Adding it to the propagatedBuildInputs makes it runnable again. It can't connect to the d-bus but I guess that should work if you have your other braille tools set up properly.

Also libluois was removed as a dependency because it had previously been broken - now it works again and we can use it as a dep here :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

worldofpeace commented Apr 24, 2019 •
edited

It can't connect to the d-bus but I guess that should work if you have your other braille tools set up properly.

Not sure what you mean by the dbus not working?

Otherwise LGTM.

Edit: you probably meant the at-spi-bus-launcher accessibility bus

hedning
hedning reviewed Apr 24, 2019
View reviewed changes
pkgs/applications/misc/orca/default.nix Outdated
@@ -34,8 +34,8 @@ buildPythonApplication rec {
];

propagatedBuildInputs = [
# TODO: re-add liblouis when it is fixed
pygobject3 pyatspi dbus-python pyxdg brltty speechd gst-python setproctitle
gobject-introspection # Temporary fix, see https://github.com/NixOS/nixpkgs/issues/56943
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason adding it to propagatedBuildInputs and not buildInputs? (in theory setting strictDeps = false; should work, but I haven't had any luck with that)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we only need to propagate pythonDependencies. And I think disabling strictDeps is better than adding build time dependencies to buildInputs and pretending strictDeps = true works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting the same runtime error when having strictDeps = false; though, no idea why. Seeing the same issue with guake.

Copy link
Contributor

@jtojnar jtojnar Apr 24, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, I already managed to forgot it is not overridable from buildPythonPackage #59187

We should probably fix that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, a ton of python packages have that same problem :/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fix allowing to use strictDeps = false; is now on master. Please rebase and try that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceeeee!

@hedning hedning added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 24, 2019
@hedning
Copy link
Contributor

hedning commented Apr 24, 2019

Looks like liblouis is broken in stable, but the strictDeps fix needs backporting.

@JohnAZoidberg
Copy link
Member Author

That's why I split it into two commits :)
Please cherry-pick d65f602f356b3b81cce14941dffc7e0ae65c90c3 onto stable.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 24, 2019

Hmm, I am getting the following in console on Orca startup:

** (gst-plugin-scanner:25871): CRITICAL **: 22:34:14.805: Couldn't g_module_open libpython. Reason: /nix/store/kimimvhimclyfzlncpg36zjni3wn70nq-python3-3.7.3/lib/python3.7/config-3.7m-x86_64-linux-gnu/libpython3.7m.so: cannot open shared object file: No such file or directory

** (gst-plugin-scanner:25871): CRITICAL **: 22:34:14.809: Couldn't g_module_open libpython. Reason: /nix/store/kimimvhimclyfzlncpg36zjni3wn70nq-python3-3.7.3/lib/python3.7/config-3.7m-x86_64-linux-gnu/libpython3.7m.so: cannot open shared object file: No such file or directory

Probably unrelated.

@worldofpeace
Copy link
Contributor

Hmm, I am getting the following in console on Orca startup:

** (gst-plugin-scanner:25871): CRITICAL **: 22:34:14.805: Couldn't g_module_open libpython. Reason: /nix/store/kimimvhimclyfzlncpg36zjni3wn70nq-python3-3.7.3/lib/python3.7/config-3.7m-x86_64-linux-gnu/libpython3.7m.so: cannot open shared object file: No such file or directory

** (gst-plugin-scanner:25871): CRITICAL **: 22:34:14.809: Couldn't g_module_open libpython. Reason: /nix/store/kimimvhimclyfzlncpg36zjni3wn70nq-python3-3.7.3/lib/python3.7/config-3.7m-x86_64-linux-gnu/libpython3.7m.so: cannot open shared object file: No such file or directory

Probably unrelated.

I've been seeing that a lot for python gtk applications.

@JohnAZoidberg JohnAZoidberg force-pushed the orca-liblouis branch 2 times, most recently from 7060cff to 9094451 Compare April 24, 2019 23:25
@JohnAZoidberg
Copy link
Member Author

Alright, works with strictDeps = false.
Please backport 507873f352ef4c71a94fedb25b26e8c9a83bc111 to stable.

@ofborg ofborg bot requested a review from hedning April 24, 2019 23:40
@hedning
Copy link
Contributor

hedning commented Apr 25, 2019

nit: could you change the commit message to match what's being done (eg. set strictDeps = false).

@JohnAZoidberg
orca: Set strictDeps to false
634b21f 
Wouldn't find the proper libraries/namespaces otherwise because of
NixOS#56943
@JohnAZoidberg
orca: Re-add liblouis
5354020 
liblouis works again so we can use it here again aswell.

Closes: NixOS#39427
@JohnAZoidberg
Copy link
Member Author

JohnAZoidberg commented Apr 25, 2019 •
edited

Sure, had left it because it still kind of does that. But I see that that's confusing.
Now backport 634b21f to stable.

@JohnAZoidberg
Copy link
Member Author

Hmm, I am getting the following in console on Orca startup:

** (gst-plugin-scanner:25871): CRITICAL **: 22:34:14.805: Couldn't g_module_open libpython. Reason: /nix/store/kimimvhimclyfzlncpg36zjni3wn70nq-python3-3.7.3/lib/python3.7/config-3.7m-x86_64-linux-gnu/libpython3.7m.so: cannot open shared object file: No such file or directory

** (gst-plugin-scanner:25871): CRITICAL **: 22:34:14.809: Couldn't g_module_open libpython. Reason: /nix/store/kimimvhimclyfzlncpg36zjni3wn70nq-python3-3.7.3/lib/python3.7/config-3.7m-x86_64-linux-gnu/libpython3.7m.so: cannot open shared object file: No such file or directory

Probably unrelated.

I think that might be because gst-python doesn't have python as a buildInput. You could try that. But yes, seems to be unrelated.

@hedning hedning merged commit 622fb28 into NixOS:master Apr 25, 2019
@hedning
Copy link
Contributor

hedning commented Apr 25, 2019

Cherry-picked in b12b1e2

@JohnAZoidberg JohnAZoidberg deleted the orca-liblouis branch April 25, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JohnAZoidberg @worldofpeace @hedning @jtojnar