Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plex: 1.15.3.876 -> 1.15.4.994 #60173

Merged
merged 1 commit into from May 10, 2019
Merged

plex: 1.15.3.876 -> 1.15.4.994 #60173

merged 1 commit into from May 10, 2019

Conversation

bachp
Copy link
Member

@bachp bachp commented Apr 24, 2019

Motivation for this change

Update to latest version.

This includes the changes from #56565 which causes merge conflicts otherwiese.

Sucessfully running on my server.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bachp
Copy link
Member Author

bachp commented Apr 24, 2019

Rebased after #56565 merge

@averelld
Copy link
Contributor

Tested as well, works fine.

@elseym
Copy link
Member

elseym commented Apr 30, 2019

Works on top of current master.

@bachp bachp changed the title plex: 1.15.3.876 -> 1.15.4.993 plex: 1.15.3.876 -> 1.15.4.994 May 9, 2019
@bachp
Copy link
Member Author

bachp commented May 9, 2019

Version 1.15.4.994 was released in the meantime. I updated the PR accordingly.

@elseym
Copy link
Member

elseym commented May 10, 2019

thank you, @bachp

just deployed it. works like a charm on top of the current master.

@LnL7 LnL7 merged commit a5a389e into NixOS:master May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants