jupyterlab: Fix build #60159
Merged
jupyterlab: Fix build #60159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build was broken by updating the underlying python library. This is the quickfix. Fixes: ca67a72 ("python37Packages.jupyterlab_server: 0.2.0 -> 0.3.0") Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
|
@dotlambda and @tcosmo might be interested in this. |
|
Thank you! |
dotlambda
requested changes
Apr 24, 2019
| patches = [ | ||
| (fetchpatch { | ||
| name = "Bump-jupyterlab_server-version"; | ||
| url = "https://github.com/jupyterlab/jupyterlab/commit/3b8d451e6f9a4c609e60cde5fbb3cc84aae79951.patch"; |
There was a problem hiding this comment.
Suggested change
| url = "https://github.com/jupyterlab/jupyterlab/commit/3b8d451e6f9a4c609e60cde5fbb3cc84aae79951.patch"; | |
| url = https://github.com/jupyterlab/jupyterlab/commit/3b8d451e6f9a4c609e60cde5fbb3cc84aae79951.patch; |
| @@ -22,6 +23,14 @@ buildPythonPackage rec { | |||
| "--set" "JUPYTERLAB_DIR" "$out/share/jupyter/lab" | |||
| ]; | |||
|
|
|||
| patches = [ | |||
| (fetchpatch { | |||
| name = "Bump-jupyterlab_server-version"; | |||
There was a problem hiding this comment.
Suggested change
| name = "Bump-jupyterlab_server-version"; | |
| name = "bump-jupyterlab_server-version.patch"; |
|
@GrahamcOfBorg build python37Packages.jupyterlab |
matthiasbeyer
force-pushed
the
fix-jupyterlab
branch
from
a15abe9
to
ef798d1
Compare
|
Rebased on latest master and squashed the commits. Ready for merge from my side. |
|
@GrahamcOfBorg build python3.pkgs.jupyterlab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build was broken by updating the underlying python library.
This is the quickfix.
Fixes: ca67a72 ("python37Packages.jupyterlab_server: 0.2.0 -> 0.3.0")
Closes #60154
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"