New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging next #60169
Merged
Merged
Staging next #60169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: nixos
6.topic: pantheon
The Pantheon desktop environment
6.topic: python
6.topic: stdenv
Standard environment
8.has: documentation
8.has: module (update)
10.rebuild-darwin-stdenv
10.rebuild-linux-stdenv
8.has: clean-up
8.has: package (new)
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
labels
Apr 24, 2019
(cherry picked from commit 1709d3a)
Fix for #59225 regression proposed by @matthewbauer #59225 (comment) (cherry picked from commit a6ea72a)
@volth Cherry picked those. For future reference those usually these cross build things can go directly to master. |
@matthewbauer the wasm change broke the tarball job due to a failing test https://hydra.nixos.org/build/92604062 |
This undoes 6fb0e7a The only problem with 6.04 is: it got new dependencies which fail to cross-compile. Failure to cross-compile HTTP::Deamon leads to failure of LWP and XML::Parser, which are used in switch-to-configuration.pl Thus upgrade HTTPDaemon from 6.01 to 6.04 broke cross-compilation of whole system closures. (cherry picked from commit fd1ac66)
We want to make sure this value is explicitly set. Infering it for every arch leads to annoying failures like: https://hydra.nixos.org/build/92583832/ Perhaps we can enable it in the future with some smarter handling of cc-wrapper.sh.
Was propagated by networkmanager before.
Includes security fixes! https://roy.marples.name/blog/dhcpcd-7-2-1-released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: nixos
6.topic: pantheon
The Pantheon desktop environment
6.topic: python
6.topic: stdenv
Standard environment
8.has: clean-up
8.has: documentation
8.has: module (update)
8.has: package (new)
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-darwin-stdenv
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
10.rebuild-linux-stdenv
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)