Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lollypop: 1.0.5 -> 1.0.7, other stuff #60170

Merged
merged 3 commits into from Apr 26, 2019
Merged

lollypop: 1.0.5 -> 1.0.7, other stuff #60170

merged 3 commits into from Apr 26, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 24, 2019

I can remember being corrected from using lib to stdenv.lib in packages when I started contributing to nixpkgs but I am not really sure why would we prefer the longer form.

@worldofpeace
Copy link
Contributor Author

I'd usually just use lib in python packages because you don't need stdenv.mkDerivation.
Elsewhere I correct people to use stdenv.lib but I share your confusion on that part.

@worldofpeace worldofpeace merged commit 07f9616 into NixOS:master Apr 26, 2019
@worldofpeace worldofpeace deleted the lollypop-bump branch April 26, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar