Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R: 3.5.3 -> 3.6.0 #60273

Closed
wants to merge 1 commit into from
Closed

R: 3.5.3 -> 3.6.0 #60273

wants to merge 1 commit into from

Conversation

jabranham
Copy link
Contributor

The patch is necessary for the test suite to pass without errors. The
fix has already been made upstream but didn't make it into the 3.6.0
release.

Motivation for this change

upstream release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jabranham jabranham requested a review from peti as a code owner April 26, 2019 16:06
@jabranham
R: 3.5.3 -> 3.6.0
b5554a7 
The patch is necessary for the test suite to pass without errors. The
fix has already been made upstream but didn't make it into the 3.6.0
release.
@ofborg ofborg bot requested a review from peti April 27, 2019 13:15
@peti
Copy link
Member

peti commented Apr 27, 2019

Merged to r-updates in 4c97534ac989d79280c07172ee17924accd810b8. Test builds will be running at https://hydra.nixos.org/jobset/nixpkgs/r-updates.

@timokau
Copy link
Member

timokau commented Apr 28, 2019

@peti mind cherry-picking timokau@be881ce too? I'd do it myself but I don't know if you do force-pushes on that branch.

@timokau timokau mentioned this pull request Apr 28, 2019
Merged
10 tasks
@peti
Copy link
Member

peti commented Apr 29, 2019

@peti mind cherry-picking timokau@be881ce too? I'd do it myself but I don't know if you do force-pushes on that branch.

Done.

@peti peti closed this in 4264ad4 Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

Assignees
No one assigned
Labels
0.kind: enhancement 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jabranham @peti @timokau