Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoGebra: 472 -> 535 #60272

Merged
merged 2 commits into from Apr 29, 2019
Merged

GeoGebra: 472 -> 535 #60272

merged 2 commits into from Apr 29, 2019

Conversation

BenBals
Copy link
Contributor

@BenBals BenBals commented Apr 26, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The main motivation for this update is that the old version is not available from GeoGebra-Servers anymore.

@BenBals
Copy link
Contributor Author

BenBals commented Apr 29, 2019

@Ma27, any opinions on this?

@Ma27
Copy link
Member

Ma27 commented Apr 29, 2019

Built and tested locally 👍

@Ma27 Ma27 merged commit 535c38d into NixOS:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BenBals @Ma27 @danieldk