Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xkcd-font: init at 2017-08-24 #60195

Merged
merged 2 commits into from Apr 25, 2019
Merged

xkcd-font: init at 2017-08-24 #60195

merged 2 commits into from Apr 25, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Apr 25, 2019

Motivation for this change

Add https://github.com/ipython/xkcd-font/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam changed the title Init xkcd font xkcd-font: init at 2017-08-24 Apr 25, 2019
JohnAZoidberg
JohnAZoidberg approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! :D
Tried it, shows up in fc-list and works in LibreOffice.

@c0bw3b c0bw3b merged commit 1746dc2 into NixOS:master Apr 25, 2019
@marsam marsam deleted the init-xkcd-font branch April 25, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @JohnAZoidberg @c0bw3b