Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmux: 2.8 -> 2.9 #60194

Merged
merged 1 commit into from Apr 26, 2019
Merged

tmux: 2.8 -> 2.9 #60194

merged 1 commit into from Apr 26, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 25, 2019 •
edited

Motivation for this change

Update tmux to the latest release.
https://github.com/tmux/tmux/releases/tag/2.9
Changes: https://raw.githubusercontent.com/tmux/tmux/2.9/CHANGES

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from fpletz April 25, 2019 02:28
c00w
c00w approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@c00w c00w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

  • ran tmux, byobu, overmind locally via nix-review pr and it worked
  • change is minor refactoring + version bump

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/22

@NeQuissimus NeQuissimus merged commit ee48e78 into NixOS:master Apr 26, 2019
@xrelkd xrelkd deleted the update/tmux branch April 26, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c00w c00w c00w approved these changes

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xrelkd @nixos-discourse @c00w @NeQuissimus