Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-manager: 2018-11-04 -> 2019-04-23 #60221

Closed
wants to merge 1 commit into from
Closed

home-manager: 2018-11-04 -> 2019-04-23 #60221

wants to merge 1 commit into from

Conversation

mtrsk
Copy link
Member

@mtrsk mtrsk commented Apr 25, 2019

Motivation for this change

Updating home-manager to a 2019-04-23 release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from rycee April 25, 2019 16:11
@rycee
Copy link
Member

rycee commented Apr 25, 2019

Thanks! Rebased to master in 1d54250.

@rycee rycee closed this Apr 25, 2019
@mtrsk mtrsk deleted the update-home-manager-2019-04-23 branch April 25, 2019 21:04
@mtrsk
Copy link
Member Author

mtrsk commented Apr 26, 2019 •
edited

Now I've realized something, both the install and some deps also changed.

New deps:

{ bash, coreutils, findutils, gnused, less, stdenv, makeWrapper, fetchFromGitHub }:

would the script change to this?

    install -v -D -m755 ${src}/home-manager/home-manager $out/bin/home-manager

    substituteInPlace $out/bin/home-manager \
      --subst-var-by bash "${bash}" \
      --subst-var-by coreutils "${coreutils}" \
      --subst-var-by findutils "${findutils}" \
      --subst-var-by gnused "${gnused}" \
      --subst-var-by less "${less}" \
      --subst-var-by HOME_MANAGER_PATH '${src}'

EDIT: Tried the following as an overlay on my system and seems to work:

self: super:

{
  home-manager = super.home-manager.overrideAttrs ( old: rec {
    name = "home-manager-${version}";
    version = "2019-04-23";
    src = super.fetchFromGitHub {
      owner = "rycee";
      repo = "home-manager";
      rev = "ba0375bf06e0e0c3b2377edf913b7fddfd5a0b40";
      sha256 = "1ksr8fw5p5ai2a02whppc0kz9b3m5363hvfjghkzkd623kfh9073";
    };
    installPhase = with super; ''
      install -v -D -m755 ${src}/home-manager/home-manager $out/bin/home-manager

      substituteInPlace $out/bin/home-manager \
        --subst-var-by bash "${bash}" \
        --subst-var-by coreutils "${coreutils}" \
        --subst-var-by findutils "${findutils}" \
        --subst-var-by gnused "${gnused}" \
        --subst-var-by less "${less}" \
        --subst-var-by HOME_MANAGER_PATH '${src}'
    '';
  });
}

@mtrsk mtrsk mentioned this pull request Apr 26, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mtrsk @rycee