Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minecraft-server: 1.13.2 -> 1.14 #60264

Merged
merged 3 commits into from Apr 30, 2019
Merged

minecraft-server: 1.13.2 -> 1.14 #60264

merged 3 commits into from Apr 30, 2019

Conversation

angristan
Copy link
Member

@angristan angristan commented Apr 26, 2019 •
edited

Motivation for this change

Add latest version of minecraft-server.

Things done

Added minecraft-server_1_14.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@angristan angristan changed the title Update minecraft-server to 1.14 minecraft-server: 1.13.2 -> 1.14 Apr 26, 2019
@ofborg ofborg bot requested a review from thoughtpolice April 26, 2019 12:40
@aanderse
Copy link
Member

As someone who has never played minecraft before I'm just curious as to why so many versions of minecraft are needed... 🤔

@angristan
Copy link
Member Author

Some people don't want the new features/changes. But I guess we could at least remove 1.13.0 and 1.13.1?

@angristan
minecraft-server: remove 1.13.0 and 1.13.1
384c643 
It does not make sense to keep outdated minor versions
@NeQuissimus NeQuissimus merged commit c7b36b7 into NixOS:master Apr 30, 2019
@angristan angristan deleted the minecraft-server-1.14 branch April 30, 2019 14:44
@Taeradan
Copy link
Contributor

This commit should be in 19.03 too, the up to date Minecraft client refuses to connect to a server with version < 1.14.

@NeQuissimus
Copy link
Member

@Taeradan 72c2c58

@Taeradan
Copy link
Contributor

@NeQuissimus thanks, but you only cherry-picked the removal of old versions, 7a26cff and a282ff4 are needed too to add version 1.14 :)
In my first comment, I think I forgot an "s" in the word "commit".

@NeQuissimus
Copy link
Member

NeQuissimus commented May 11, 2019 •
edited

Oops :D Let me fix that

356010e 111412e

@Taeradan
Copy link
Contributor

Thanks again, the new version arrived on my server during an auto update last night, everything seems OK !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@angristan @aanderse @Taeradan @NeQuissimus @Janik-Haag