Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neo.map: fix URL #60201

Merged
merged 1 commit into from May 10, 2019
Merged

neo.map: fix URL #60201

merged 1 commit into from May 10, 2019

Conversation

samsonan-it
Copy link
Contributor

Motivation for this change

Current URL is no longer available, due to the migration from svn to github.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samsonan-it
neo.map: fix URL
6e100ae 
Current URL is no longer available.
teto
teto reviewed Apr 25, 2019
View reviewed changes
pkgs/os-specific/linux/kbd/keymaps.nix
@@ -24,7 +24,8 @@

src = fetchurl {
name = "neo.map";
url = "https://svn.neo-layout.org/linux/console/neo.map?r=${version}";
url = "https://raw.githubusercontent.com/neo-layout/neo-layout/"
+ "a0dee06fed824abfad658b7f10e6d907b270be0a/linux/console/neo.map";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't that depend on version too ? or just give the github link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends on specific github commit which corresponds to the version 2476 migrated from svn. This url points to the raw version of github file https://github.com/neo-layout/neo-layout/blob/a0dee06fed824abfad658b7f10e6d907b270be0a/linux/console/neo.map .

@teto
Copy link
Member

teto commented Apr 25, 2019

while you are at it could you replace "name" by "pname" ? name will be generated from pname and version

matthiasbeyer
matthiasbeyer requested changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @teto said

@nixbitcoin
Copy link
Contributor

Running into same error while testing fort-nix/nix-bitcoin#48 . Can I help fix this in any way?

This was referenced May 7, 2019
Merged
Closed
@c0bw3b
Copy link
Contributor

c0bw3b commented May 10, 2019

@GrahamcOfBorg build kbd

@c0bw3b c0bw3b merged commit 0fe5e02 into NixOS:master May 10, 2019
vcunat pushed a commit that referenced this pull request May 19, 2019
@samsonan-it @vcunat
Merge #60201: neo.map: fix URL
3366e98 
Current URL is no longer available.

(cherry picked from commit 6e100ae)
Close #61698.
vcunat pushed a commit that referenced this pull request May 19, 2019
@samsonan-it @vcunat
Merge #60201: neo.map: fix URL
a7e559a 
Current URL is no longer available.

(cherry picked from commit 6e100ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto left review comments

@matthiasbeyer matthiasbeyer matthiasbeyer requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@samsonan-it @teto @nixbitcoin @c0bw3b @matthiasbeyer @Janik-Haag