Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains-jdk: 8.202b1483.37 -> 11.0.2b164 #60208

Merged
merged 1 commit into from Apr 29, 2019
Merged

jetbrains-jdk: 8.202b1483.37 -> 11.0.2b164 #60208

merged 1 commit into from Apr 29, 2019

Conversation

lheckemann
Copy link
Member

Motivation for this change

Fancy Java 11 stuff. I haven't tested this exhaustively, but PHPStorm does run with this.

cc @calbrecht

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edwtjo April 25, 2019 13:17
@calbrecht
Copy link
Member

Works good for me, too. 👍

Ma27
Ma27 approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with phpstorm and idea-community 👍

@averelld averelld mentioned this pull request Apr 26, 2019
Merged
10 tasks
@lheckemann lheckemann merged commit 99e1612 into NixOS:master Apr 29, 2019
@lheckemann lheckemann deleted the jetbrains-jdk11 branch April 29, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lheckemann @calbrecht @Ma27