Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lorri: init at 2019-04-24 #60211

Closed
wants to merge 1 commit into from
Closed

lorri: init at 2019-04-24 #60211

wants to merge 1 commit into from

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Apr 25, 2019

Motivation for this change

Add https://github.com/target/lorri

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tomberek tomberek mentioned this pull request Apr 25, 2019
Closed
Profpatsch
Profpatsch requested changes Apr 25, 2019
View reviewed changes
Copy link
Member

@Profpatsch Profpatsch left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but we don’t want to add lorri to nixpkgs yet, because it is not yet stable; people should use the installation instructions provided on the project page.

I suggest adding the lorri attribute anyhow, but like that:

lorri = throw "lorri is not stable yet. Please go to https://github.com/target/lorri and follow the installation instructions there for the time being"

@marsam
Copy link
Contributor Author

marsam commented Apr 25, 2019

[...] we don’t want to add lorri to nixpkgs yet

sure, no problem

@marsam marsam closed this Apr 25, 2019
@marsam marsam deleted the init-lorri branch April 25, 2019 18:17
@Profpatsch Profpatsch mentioned this pull request Apr 26, 2019
Merged
1 task
Profpatsch added a commit that referenced this pull request Apr 29, 2019
@Profpatsch
lorri: reserve attribute name
d6ec946 
lorri is a nix-shell replacement for project development.
Since it’s public beta announcement was noticed by many people, they
are going to assume it is available from nixpkgs. We lead them to the
installation instructions while the tool is not yet ready for nixpkgs.

Related-issue: #60211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Profpatsch requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @Profpatsch