Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyhamcrest: switch from application to package #60214

Merged
merged 1 commit into from Apr 29, 2019
Merged

pythonPackages.pyhamcrest: switch from application to package #60214

merged 1 commit into from Apr 29, 2019

Conversation

exarkun
Copy link
Contributor

@exarkun exarkun commented Apr 25, 2019 •
edited by dotlambda

pyhamcrest is a testing library with no application component.

closes #60213

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@exarkun
pyhamcrest: switch from application to package
ca6589d 
pyhamcrest is a testing library with no application component.
@exarkun exarkun requested a review from FRidh as a code owner April 25, 2019 13:51
@FRidh
Copy link
Member

FRidh commented Apr 25, 2019

Applications shouldn't be under python-modules, so that's good.

@dotlambda dotlambda changed the title pyhamcrest: switch from application to package pythonPackages.pyhamcrest: switch from application to package Apr 26, 2019
@dotlambda dotlambda merged commit 54c22e6 into NixOS:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pyhamcrest is packaged as an application instead of a library
3 participants
@exarkun @FRidh @dotlambda