Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.gita: 0.8.2 -> 0.9.2 #60212

Merged
merged 1 commit into from May 1, 2019
Merged

gitAndTools.gita: 0.8.2 -> 0.9.2 #60212

merged 1 commit into from May 1, 2019

Conversation

seqizz
Copy link
Contributor

@seqizz seqizz commented Apr 25, 2019 •
edited

Motivation for this change

Version bump, also overriding the pyyaml for python, since the package depends on the new version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

matthiasbeyer
matthiasbeyer requested changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should tell why the override was necessary.

Or even better: A comment in the sourcecode. So that we know when to remove the override (probably when switching to a newer python version as python3).

@seqizz
Copy link
Contributor Author

seqizz commented Apr 26, 2019

Added a comment into the file

c0bw3b
c0bw3b requested changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyyaml v5.1 is in nixpkgs since #57688 and already in master.
This PR should just bump gita

@seqizz
Copy link
Contributor Author

seqizz commented Apr 30, 2019

Didn't realize the new version, thanks. Should be OK now.

@c0bw3b
Copy link
Contributor

c0bw3b commented May 1, 2019

@GrahamcOfBorg build gitAndTools.gita

@c0bw3b c0bw3b merged commit 3392411 into NixOS:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seqizz @c0bw3b @matthiasbeyer