Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docbook-xsl: 1.79.1 → 1.79.2 #60270

Merged
merged 1 commit into from Apr 30, 2019
Merged

docbook-xsl: 1.79.1 → 1.79.2 #60270

merged 1 commit into from Apr 30, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Apr 26, 2019

Motivation for this change

Nothing much changed other than adding the suffix -nons to Docbook 4 styles, making the Docbook 5 the variant without suffix:

https://github.com/docbook/xslt10-stylesheets/releases/tag/release%2F1.79.2

I have decided to make docbook_xsl an alias of docbook-xsl-nons for now, to avoid confusion.

Will move the aliases.nix in later iteration.

I also updated patch link that was broken to a newer version of the patch
and started sharing it between the two packages.

Closes: #60259

Things done

I diffed the directory trees with 1.79.1, the only non-trivial change seems to be the merging of the schema files.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar changed the title Docbook xsl 1.79.2 docbook-xsl-nons: 1.79.1 → 1.79.2 Apr 26, 2019
@ofborg ofborg bot requested review from edolstra, lovek323 and andir April 26, 2019 14:54
@jtojnar jtojnar changed the title docbook-xsl-nons: 1.79.1 → 1.79.2 docbook-xsl: 1.79.1 → 1.79.2 Apr 26, 2019
@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 30, 2019

Hmm, apparently the catalog only contains the new canonical URLs, wee will need to add the legacy URLs.

@jtojnar
docbook-xsl-nons: 1.79.1 → 1.79.2
013ddbe 
Nothing much changed other than adding the suffix -nons to Docbook 4 styles,
making the Docbook 5 the variant without suffix:

https://github.com/docbook/xslt10-stylesheets/releases/tag/release%2F1.79.2

I have decided to make docbook_xsl an alias of docbook-xsl-nons for now,
to avoid confusion.

I also updated patch link that was broken to a newer version of the patch
and started sharing it between the two packages.
@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 30, 2019 •
edited

Successfully built:

  • nix-build -A shadow
  • nix-build nixos/release.nix -A manual.x86_64-linux

@jtojnar jtojnar merged commit a5c04ea into NixOS:staging Apr 30, 2019
@jtojnar jtojnar deleted the docbook-xsl-1.79.2 branch April 30, 2019 20:03
@jtojnar jtojnar mentioned this pull request May 1, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@lovek323 lovek323 Awaiting requested review from lovek323

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
8.has: documentation 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jtojnar