Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledmon: init at 0.92 #60206

Merged
merged 1 commit into from Apr 26, 2019
Merged

ledmon: init at 0.92 #60206

merged 1 commit into from Apr 26, 2019

Conversation

sorki
Copy link
Member

@sorki sorki commented Apr 25, 2019

Motivation for this change

New package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar reviewed Apr 25, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some tips to make the expression more idiomatic.

pkgs/tools/system/ledmon/default.nix Outdated Show resolved Hide resolved
pkgs/tools/system/ledmon/default.nix Outdated Show resolved Hide resolved
pkgs/tools/system/ledmon/default.nix Outdated Show resolved Hide resolved
pkgs/tools/system/ledmon/default.nix Outdated Show resolved Hide resolved
@sorki
Copy link
Member Author

sorki commented Apr 26, 2019

Updated, thank you!

@jtojnar jtojnar merged commit 664c82c into NixOS:master Apr 26, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Apr 26, 2019

Thanks.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 26, 2019 •
edited

Oh, I missed that the manpage does not build. Fixed in 358c626.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sorki @jtojnar