New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
icu: 59 -> 64 #60250
Merged
Merged
icu: 59 -> 64 #60250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you rebase? It appears there are some incorrect commits. |
@GrahamcOfBorg build icu |
vcunat
added a commit
that referenced
this pull request
Jun 5, 2019
It's exactly the same issue as in the parent commit. /cc #60250 (2fe63c8).
I managed to fix a few regressions quickly. PyICU is the only remaining problem I know about; there the compile flags isn't respected I suspect. |
Hopefully fine now: 326148ec9 |
This pull request has been mentioned on Nix community. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/unicode-org/icu/releases/tag/release-64-2
They say updates can go smoothly so let's try! (http://userguide.icu-project.org/icufaq)
We should probably get rid of the old versions that are not needed anymore if everything builds after this. It doesn't look like they have any LTS versions - they're just releasing new versions.
Obsoletes or resolves: #39388 and #52632
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)