Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.jinja2: 2.10 -> 2.10.1 #60251

Closed
wants to merge 2 commits into from
Closed

python.pkgs.jinja2: 2.10 -> 2.10.1 #60251

wants to merge 2 commits into from

Conversation

dotlambda
Copy link
Member

Motivation for this change

fixes CVE-2019-10906
https://palletsprojects.com/blog/jinja-2-10-1-released/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Apr 26, 2019
@dotlambda dotlambda requested a review from FRidh as a code owner April 26, 2019 07:20
@dotlambda
Copy link
Member Author

dotlambda commented Apr 26, 2019 •
edited

I just discovered that the upgrade is already in staging. Not sure if this can be merged directly into master.
EDIT: It definitely can't. We should thus backport 5bcf827 to staging-19.03.

@FRidh
Copy link
Member

FRidh commented Apr 26, 2019

It being a mass-rebuild I suggest waiting for the staging commit. We can backport, though probably to staging-19.03.

@dotlambda
Copy link
Member Author

Backported the update as 336d98c.

Should we merge 87bacfa into staging?

@FRidh
Copy link
Member

FRidh commented Apr 26, 2019

yes

@dotlambda dotlambda closed this Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dotlambda @FRidh