Teach worker threads how to pause #16563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 26, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1582265
branch
5 times, most recently
from
5327636
to
50dbe9d
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1582265
branch
5 times, most recently
from
b485994
to
11cdfb3
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1582265
branch
from
11cdfb3
to
7393dd4
Compare
Inspector uses a V8 interrupt and a nested event loop to pause workers. Extract this functionality out of the worker thread debugger and add it to the worker thread itself. Call these pause/resume functions for dedicated workers when a frame freeze's itself as well. Test this new functionality in unit tests. BUG=907125 Change-Id: I9cd2c27803ecf30ad8e6ac780b05a055234e3ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582265 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#659530}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1582265
branch
from
7393dd4
to
d9caff8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspector uses a V8 interrupt and a nested event loop to pause
workers. Extract this functionality out of the worker thread debugger and
add it to the worker thread itself. Call these pause/resume functions for
dedicated workers when a frame freeze's itself as well.
Test this new functionality in unit tests.
BUG=907125
Change-Id: I9cd2c27803ecf30ad8e6ac780b05a055234e3ffb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582265
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659530}