Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pysnooper: init at 0.3.0 #60228

Merged
merged 2 commits into from Jan 8, 2020
Merged

pythonPackages.pysnooper: init at 0.3.0 #60228

merged 2 commits into from Jan 8, 2020

Conversation

seqizz
Copy link
Contributor

@seqizz seqizz commented Apr 25, 2019

Motivation for this change

pysnooper is a python logging library, providing quick logging via decorator

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@seqizz seqizz requested a review from FRidh as a code owner April 25, 2019 20:14
@seqizz seqizz force-pushed the g_pysnooper branch 2 times, most recently from b353293 to 5511c5f Compare April 26, 2019 12:28
dotlambda
dotlambda requested changes Apr 26, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a separate commit for each package.

@seqizz
Copy link
Contributor Author

seqizz commented Apr 26, 2019

Should be ok know, could you re-check. Also thanks for patience.

dotlambda
dotlambda requested changes Apr 26, 2019
View reviewed changes
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/python_toolbox/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/python_toolbox/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pysnooper/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pysnooper/default.nix Outdated Show resolved Hide resolved
@seqizz seqizz force-pushed the g_pysnooper branch 2 times, most recently from 86a4362 to cffc48b Compare April 26, 2019 18:51
@seqizz seqizz changed the title pythonPackages.pysnooper: init at 0.0.21 pythonPackages.pysnooper: init at 0.0.22 Apr 26, 2019
@seqizz
Copy link
Contributor Author

seqizz commented Apr 26, 2019

Re-pushed with suggested changes

dotlambda
dotlambda requested changes Apr 26, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first commit message needs to be amended.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pysnooper python3.pkgs.pysnooper

@seqizz
Copy link
Contributor Author

seqizz commented Apr 26, 2019

Pushed again

@dotlambda
Copy link
Member

@seqizz cool-RR/python_toolbox#3 seems to have been resolved.

@seqizz
Copy link
Contributor Author

seqizz commented May 3, 2019

Switched to fetchFromGitHub to get the latest release. Yet not sure how to test this 😕 I can't see the tests on pysnooper build when I try, since there is no way to say "force rebuild" on nix-shell or nix-build as far as I can find.

@seqizz seqizz changed the title pythonPackages.pysnooper: init at 0.0.22 pythonPackages.pysnooper: init at 0.1.0 May 31, 2019
@seqizz
Copy link
Contributor Author

seqizz commented May 31, 2019

Pushed 0.1.0

@FRidh
Copy link
Member

FRidh commented Jul 20, 2019

@GrahamcOfBorg build pythonPackages.pysnooper python3Packages.pysnooper

@seqizz
Copy link
Contributor Author

seqizz commented Jul 25, 2019

I think github is confused, suggested change is already done..
I wish I could've helped maintaining the nixos repo more, since I can see the MR/issue pile 😶 But you can see the quality of my commits already 😬

@seqizz seqizz changed the title pythonPackages.pysnooper: init at 0.1.0 pythonPackages.pysnooper: init at 0.2.4 Aug 7, 2019
@seqizz
Copy link
Contributor Author

seqizz commented Aug 7, 2019

After this much time, I guess I know a bit more what I am doing 😃
Upgraded to latest version, also built fine on my box.

@seqizz seqizz changed the title pythonPackages.pysnooper: init at 0.2.4 pythonPackages.pysnooper: init at 0.2.8 Oct 6, 2019
@seqizz seqizz changed the title pythonPackages.pysnooper: init at 0.2.8 pythonPackages.pysnooper: init at 0.3.0 Dec 30, 2019
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/81

jonringer
jonringer approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM
has tests 👍

failures appear to be upstream issues

[5 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/c07fmi7g9j9ggfy9jkwcddq53ycny9g0-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/60228
2 package failed to build:
python38Packages.pysnooper python38Packages.python-toolbox

3 package built:
python27Packages.pysnooper python37Packages.pysnooper python37Packages.python-toolbox

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.pysnooper python37Packages.pysnooper python37Packages.python-toolbox

@jonringer jonringer merged commit 0def56c into NixOS:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@seqizz @dotlambda @FRidh @nixos-discourse @jonringer