Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epubcheck: init at 4.2.0 #60218

Merged
merged 1 commit into from Apr 26, 2019
Merged

epubcheck: init at 4.2.0 #60218

merged 1 commit into from Apr 26, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Apr 25, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aanderse
aanderse requested changes Apr 26, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few very minor things I noticed. Will build locally and see if anything else jumps out when I get a chance. 👍

pkgs/tools/text/epubcheck/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/epubcheck/default.nix Show resolved Hide resolved
@aanderse
Copy link
Member

@GrahamcOfBorg build epubcheck

@aanderse
Copy link
Member

aarch64-linux failure unrelated to this PR, but probably fixed by @JohnAZoidberg in #60224.

@aanderse aanderse merged commit d872d32 into NixOS:master Apr 26, 2019
@eadwu eadwu deleted the init/epubcheck branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eadwu @aanderse