Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elpi: 1.2.0 -> 1.4.1 #63811

Merged
merged 1 commit into from Jun 27, 2019
Merged

elpi: 1.2.0 -> 1.4.1 #63811

merged 1 commit into from Jun 27, 2019

Conversation

CohenCyril
Copy link
Contributor

Motivation for this change

Upgrade elpi to latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CohenCyril
Copy link
Contributor Author

@vbgl is it ok?

@vbgl
Copy link
Contributor

vbgl commented Jun 27, 2019

Does it subsumes #63727?

@CohenCyril
Copy link
Contributor Author

@vbgl It does since this is a derivation for release 1.4.1 from yesterday, but your derivation in #63727 was smaller (I did not try to filter out unused dependencies since 1.2.0)

@CohenCyril
Copy link
Contributor Author

@vbgl now should be strictly one release bump from #63727

@vbgl
Copy link
Contributor

vbgl commented Jun 27, 2019

@GrahamcOfBorg build ocamlPackages.elpi

@vbgl vbgl merged commit 7e90540 into NixOS:master Jun 27, 2019
@vbgl vbgl mentioned this pull request Jun 27, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CohenCyril @vbgl