After some investigation on IRC, looks like this is due to #63533

#64475 has been resolved.

You know, something like this does seem a lot better than the nasty backslash thing anyway; oughtn't we have a better standard?

It does improve the code. At first I thought of it as an ad-hoc fix to something that's already been fixed/reverted in systemd so it wasn't needed anymore. But it does seem fine as a standalone improvement.

If you can test @gloaming I'd be happy to reopen and merge this.

This is my first PR, so not sure if I did some of the testing stuff correctly. nix-shell -p nix-review --run "nix-review rev undervolt-fix" reported "Nothing changed" for example.

@zmlww Welcome! nix-review only tests changes to packages, but the change here is to a NixOS module. The module depends on the package, but not the other way around, so there's nothing for nix-review to check.

@worldofpeace I think I'll experiment with writing a combinator that we can use to compose ExecStart lines in a more principled way than manually checking for nulls and combining strings.