Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 85483ca76a04
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 94e8afc254d7
Choose a head ref
  • 15 commits
  • 12 files changed
  • 2 contributors

Commits on Jun 25, 2019

  1. meson: enable auto_features by default

    We disabled them by default when they were introduced in
    
    #42994
    
    but enabling them probably makes more sense:
    
    #54398
    #63491
    jtojnar committed Jun 25, 2019

    Unverified

    The email in this signature doesn’t match the committer email.
    Copy the full SHA
    e529ec3 View commit details
  2. meson: do not download wraps

    jtojnar committed Jun 25, 2019

    Unverified

    The email in this signature doesn’t match the committer email.
    Copy the full SHA
    0fd5abb View commit details
  3. meson: use plain buildtype

    This should allow us to inherit optimization/striping from stdenv
    jtojnar committed Jun 25, 2019

    Unverified

    The email in this signature doesn’t match the committer email.
    Copy the full SHA
    41c575b View commit details
  4. Unverified

    The email in this signature doesn’t match the committer email.
    Copy the full SHA
    76d85e4 View commit details
  5. gnome3.tracker-miners: do not add auto_features=enabled

    Meson setup hook now defaults to this.
    jtojnar committed Jun 25, 2019

    Unverified

    The email in this signature doesn’t match the committer email.
    Copy the full SHA
    4fa19ba View commit details
  6. girara: fix build with auto_features=enabled

    Also split multiple outputs and enable tests.
    jtojnar committed Jun 25, 2019

    Unverified

    The email in this signature doesn’t match the committer email.
    Copy the full SHA
    3238567 View commit details
  7. Unverified

    The email in this signature doesn’t match the committer email.
    Copy the full SHA
    592a520 View commit details
  8. Unverified

    The email in this signature doesn’t match the committer email.
    Copy the full SHA
    5779747 View commit details
  9. Unverified

    The email in this signature doesn’t match the committer email.
    Copy the full SHA
    4abfebf View commit details
  10. Unverified

    The email in this signature doesn’t match the committer email.
    Copy the full SHA
    4bc87ff View commit details
  11. spice-gtk: remove auto_features=enabled from expression

    It is now default
    jtojnar committed Jun 25, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    c3fe79e View commit details
  12. wl-clipboard: remove auto_features=enabled from expression

    It is now the default.
    jtojnar committed Jun 25, 2019

    Unverified

    The email in this signature doesn’t match the committer email.
    Copy the full SHA
    1811e91 View commit details
  13. spice: remove auto_features=enabled from expression

    It is now the default.
    jtojnar committed Jun 25, 2019

    Unverified

    The email in this signature doesn’t match the committer email.
    Copy the full SHA
    c1d500d View commit details
  14. gnome3.evince: remove auto_features=enabled from expression

    It is now the default.
    jtojnar committed Jun 25, 2019

    Unverified

    The email in this signature doesn’t match the committer email.
    Copy the full SHA
    ac404cf View commit details
  15. Merge pull request #63493 from jtojnar/meson-auto-features

    meson: enable auto_features by default
    worldofpeace authored Jun 25, 2019

    Unverified

    The email in this signature doesn’t match the committer email.
    Copy the full SHA
    94e8afc View commit details
6 changes: 6 additions & 0 deletions pkgs/applications/audio/ncmpc/default.nix
Original file line number Diff line number Diff line change
@@ -15,6 +15,12 @@ stdenv.mkDerivation rec {
buildInputs = [ glib ncurses mpd_clientlib boost ];
nativeBuildInputs = [ meson ninja pkgconfig gettext ];

mesonFlags = [
"-Dlirc=disabled"
"-Dregex=disabled"
"-Ddocumentation=disabled"
];

meta = with stdenv.lib; {
description = "Curses-based interface for MPD (music player daemon)";
homepage = https://www.musicpd.org/clients/ncmpc/;
25 changes: 20 additions & 5 deletions pkgs/applications/misc/girara/default.nix
Original file line number Diff line number Diff line change
@@ -1,19 +1,34 @@
{ stdenv, fetchurl, meson, ninja, pkgconfig, glib, gtk, gettext, libiconv, libintl
{ stdenv, fetchurl, meson, ninja, pkgconfig, check, dbus, xvfb_run, glib, gtk, gettext, libiconv, json_c, libintl
}:

stdenv.mkDerivation rec {
name = "girara-${version}";
pname = "girara";
version = "0.3.2";

outputs = [ "out" "dev" ];

src = fetchurl {
url = "https://pwmt.org/projects/girara/download/${name}.tar.xz";
url = "https://pwmt.org/projects/girara/download/${pname}-${version}.tar.xz";
sha256 = "1kc6n1mxjxa7wvwnqy94qfg8l9jvx9qrvrr2kc7m4g0z20x3a00p";
};

nativeBuildInputs = [ meson ninja pkgconfig gettext ];
buildInputs = [ libintl libiconv ];
nativeBuildInputs = [ meson ninja pkgconfig gettext check dbus xvfb_run ];
buildInputs = [ libintl libiconv json_c ];
propagatedBuildInputs = [ glib gtk ];

doCheck = true;

mesonFlags = [
"-Ddocs=disabled" # docs do not seem to be installed
];

checkPhase = ''
export NO_AT_BRIDGE=1
xvfb-run -s '-screen 0 800x600x24' dbus-run-session \
--config-file=${dbus.daemon}/share/dbus-1/session.conf \
meson test --print-errorlogs
'';

meta = with stdenv.lib; {
homepage = https://pwmt.org/projects/girara/;
description = "User interface library";
6 changes: 4 additions & 2 deletions pkgs/applications/misc/zathura/core/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{ stdenv, fetchurl, meson, ninja, wrapGAppsHook, pkgconfig
, appstream-glib, desktop-file-utils, python3
, gtk, girara, gettext, libxml2
, gtk, girara, gettext, libxml2, check
, sqlite, glib, texlive, libintl, libseccomp
, file, librsvg
, gtk-mac-integration, synctexSupport ? true
@@ -33,7 +33,7 @@ stdenv.mkDerivation rec {

nativeBuildInputs = [
meson ninja pkgconfig desktop-file-utils python3.pkgs.sphinx
gettext wrapGAppsHook libxml2
gettext wrapGAppsHook libxml2 check
] ++ optional stdenv.isLinux appstream-glib;

buildInputs = [
@@ -42,6 +42,8 @@ stdenv.mkDerivation rec {
++ optional stdenv.isLinux libseccomp
++ optional stdenv.isDarwin gtk-mac-integration;

doCheck = true;

meta = {
homepage = https://pwmt.org/projects/zathura/;
description = "A core component for zathura PDF viewer";
1 change: 0 additions & 1 deletion pkgs/desktops/gnome-3/core/evince/default.nix
Original file line number Diff line number Diff line change
@@ -104,7 +104,6 @@ stdenv.mkDerivation rec {
gstreamer gst-plugins-base gst-plugins-good gst-plugins-bad gst-plugins-ugly gst-libav ]);

mesonFlags = [
"-Dauto_features=enabled"
"-Dnautilus=false"
"-Dps=enabled"
"-Dgtk_doc=false"
6 changes: 2 additions & 4 deletions pkgs/desktops/gnome-3/core/gnome-desktop/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{ stdenv, fetchurl, substituteAll, pkgconfig, libxslt, ninja, libX11, gnome3, gtk3, glib
, gettext, libxml2, xkeyboard_config, isocodes, meson, wayland
, libseccomp, bubblewrap, gobject-introspection, gtk-doc, docbook_xsl, gsettings-desktop-schemas }:
, libseccomp, systemd, bubblewrap, gobject-introspection, gtk-doc, docbook_xsl, gsettings-desktop-schemas }:

stdenv.mkDerivation rec {
name = "gnome-desktop-${version}";
@@ -13,15 +13,13 @@ stdenv.mkDerivation rec {
sha256 = "0bidx4626x7k2myv6f64qv4fzmxv8v475wibiz19kj8hjfr737q9";
};

enableParallelBuilding = true;

nativeBuildInputs = [
pkgconfig meson ninja gettext libxslt libxml2 gobject-introspection
gtk-doc docbook_xsl
];
buildInputs = [
libX11 bubblewrap xkeyboard_config isocodes wayland
gtk3 glib libseccomp
gtk3 glib libseccomp systemd
];

propagatedBuildInputs = [ gsettings-desktop-schemas ];
1 change: 0 additions & 1 deletion pkgs/desktops/gnome-3/core/tracker-miners/default.nix
Original file line number Diff line number Diff line change
@@ -104,7 +104,6 @@ stdenv.mkDerivation rec {
"-Dfunctional_tests=false"
"-Ddbus_services=${placeholder "out"}/share/dbus-1/services"
"-Dsystemd_user_services=${placeholder "out"}/lib/systemd/user"
"-Dauto_features=enabled"
];

patches = [
1 change: 0 additions & 1 deletion pkgs/development/libraries/spice-gtk/default.nix
Original file line number Diff line number Diff line change
@@ -109,7 +109,6 @@ stdenv.mkDerivation rec {
PKG_CONFIG_POLKIT_GOBJECT_1_POLICYDIR = "${placeholder "out"}/share/polkit-1/actions";

mesonFlags = [
"-Dauto_features=enabled"
"-Dcelt051=disabled"
"-Dpulse=disabled" # is deprecated upstream
];
1 change: 0 additions & 1 deletion pkgs/development/libraries/spice/default.nix
Original file line number Diff line number Diff line change
@@ -77,7 +77,6 @@ stdenv.mkDerivation rec {
NIX_CFLAGS_COMPILE = "-fno-stack-protector";

mesonFlags = [
"-Dauto_features=enabled"
"-Dgstreamer=1.0"
"-Dcelt051=disabled"
];
4 changes: 2 additions & 2 deletions pkgs/development/libraries/wlroots/default.nix
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{ stdenv, fetchFromGitHub, meson, ninja, pkgconfig
, wayland, libGL, wayland-protocols, libinput, libxkbcommon, pixman
, xcbutilwm, libX11, libcap, xcbutilimage, xcbutilerrors, mesa
, libpng, ffmpeg_4
, libpng, ffmpeg_4, freerdp
}:

stdenv.mkDerivation rec {
@@ -24,7 +24,7 @@ stdenv.mkDerivation rec {
buildInputs = [
wayland libGL wayland-protocols libinput libxkbcommon pixman
xcbutilwm libX11 libcap xcbutilimage xcbutilerrors mesa
libpng ffmpeg_4
libpng ffmpeg_4 freerdp
];

mesonFlags = [
5 changes: 3 additions & 2 deletions pkgs/development/tools/build-managers/meson/setup-hook.sh
Original file line number Diff line number Diff line change
@@ -17,10 +17,11 @@ mesonConfigurePhase() {
--includedir=${!outputInclude}/include \
--mandir=${!outputMan}/share/man --infodir=${!outputInfo}/share/info \
--localedir=${!outputLib}/share/locale \
-Dauto_features=disabled \
-Dauto_features=${mesonAutoFeatures:-enabled} \
-Dwrap_mode=${mesonWrapMode:-nodownload} \
$mesonFlags"

mesonFlags="${crossMesonFlags+$crossMesonFlags }--buildtype=${mesonBuildType:-release} $mesonFlags"
mesonFlags="${crossMesonFlags+$crossMesonFlags }--buildtype=${mesonBuildType:-plain} $mesonFlags"

echo "meson flags: $mesonFlags ${mesonFlagsArray[@]}"

3 changes: 2 additions & 1 deletion pkgs/tools/graphics/grim/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ stdenv, fetchFromGitHub, cairo, libjpeg, meson, ninja, wayland, pkgconfig, wayland-protocols }:
{ stdenv, fetchFromGitHub, cairo, libjpeg, meson, ninja, wayland, pkgconfig, scdoc, wayland-protocols }:

stdenv.mkDerivation rec {
pname = "grim";
@@ -15,6 +15,7 @@ stdenv.mkDerivation rec {
meson
ninja
pkgconfig
scdoc
];

buildInputs = [
1 change: 0 additions & 1 deletion pkgs/tools/misc/wl-clipboard/default.nix
Original file line number Diff line number Diff line change
@@ -14,7 +14,6 @@ stdenv.mkDerivation rec {

nativeBuildInputs = [ meson ninja pkgconfig wayland-protocols ];
buildInputs = [ wayland ];
mesonFlags = [ "-Dauto_features=enabled" ];

meta = with stdenv.lib; {
description = "Command-line copy/paste utilities for Wayland";