Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solc: 0.5.9 -> 0.5.10 #63776

Merged
merged 1 commit into from Jul 5, 2019
Merged

solc: 0.5.9 -> 0.5.10 #63776

merged 1 commit into from Jul 5, 2019

Conversation

sifmelcara
Copy link
Member

@sifmelcara sifmelcara commented Jun 25, 2019 •
edited

Update the package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sifmelcara
Copy link
Member Author

Could someone with @GrahamcOfBorg MacOS access help test building on MacOS? Thanks!

@srhb
Copy link
Contributor

srhb commented Jun 25, 2019

@GrahamcOfBorg build solc

@sifmelcara
Copy link
Member Author

IMO this is ready to be merged

@xrelkd
Copy link
Contributor

xrelkd commented Jul 4, 2019

LGTM! tested locally on NixOS.
Hi, @marsam I think that this PR gets stuck. Could you merge this PR? Thank you!

@marsam marsam merged commit 8cced80 into NixOS:master Jul 5, 2019
@marsam
Copy link
Contributor

marsam commented Jul 5, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sifmelcara @srhb @xrelkd @marsam