Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-expand: fix darwin build #63746

Merged
merged 1 commit into from Jun 25, 2019
Merged

cargo-expand: fix darwin build #63746

merged 1 commit into from Jun 25, 2019

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Jun 24, 2019

Motivation for this change

Fix link error on darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 labels Jun 24, 2019
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build cargo-expand

@worldofpeace worldofpeace merged commit 0d61615 into NixOS:master Jun 25, 2019
@worldofpeace
Copy link
Contributor

Thanks @arcnmx

@arcnmx arcnmx deleted the rust-darwin-expand branch July 28, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arcnmx @worldofpeace