Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepin.dtkcore: explicitly set DTK_VERSION #63795

Merged
merged 1 commit into from Jun 26, 2019
Merged

deepin.dtkcore: explicitly set DTK_VERSION #63795

merged 1 commit into from Jun 26, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jun 26, 2019

Motivation for this change

The build system fails to detect the version to build, defaulting to the minimum one. To circumvent that it has to be explicitly set.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The build system fails to detect the version to build, defaulting to
the minimum one. To circunvent that it has to be explicitly set.
@romildo
Copy link
Contributor Author

romildo commented Jun 26, 2019

See also #59023 (comment).

@worldofpeace
Copy link
Contributor

LGTM, checked the build output and it looks correct.

I'm building packages locally that used DTK_VERSION_CHECK to be sure we don't have any problems.

@worldofpeace worldofpeace merged commit 648ca9b into NixOS:master Jun 26, 2019
@romildo romildo deleted the upd.deepin.dtkcore branch June 26, 2019 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants