Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepin.dde-daemon: 3.27.2.5 -> 3.27.2.6; fix some hard coded paths #63796

Merged
merged 2 commits into from Jun 27, 2019
Merged

deepin.dde-daemon: 3.27.2.5 -> 3.27.2.6; fix some hard coded paths #63796

merged 2 commits into from Jun 27, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jun 26, 2019 •
edited

Motivation for this change
  • deepin.dde-daemon: 3.27.2.5 -> 3.27.2.6
  • deepin.dde-daemon: fix some hard coded paths

About packaging deepin for NixOS: #59023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Changelog: https://github.com/linuxdeepin/dde-daemon/blob/3.27.2.6/CHANGELOG.md

@worldofpeace
Copy link
Contributor

There's soo many hardcoded paths here, I think I'll just merge it for now 🤣

@worldofpeace worldofpeace merged commit cdeadfe into NixOS:master Jun 27, 2019
@romildo romildo deleted the upd.deepin.dde-daemon branch June 28, 2019 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @worldofpeace