This should be fine now, --enable-glx-tls doesn't seem to present on the builds I've seen while --enable-texture-float is only if we want to be backwards compatible [1].

[1] https://gitlab.freedesktop.org/mesa/mesa/commit/66673bef941af344314fe9c91cad8cd330b245eb

disk_cache-include-dri-driver-path-in-cache-key.patch seems pretty important, so I tried adding it back in? Not very familiar with meson as well but it seems to compile at least.

Is there a reason why mesa_noglu.stubs is within the derivation? It causes overrideAttrs to fail since self always references the old derivation. Doing grep -nr '\.stubs show that mesa_noglu.stubs is only used in the declaration of libGL in all-packages.nix.

self: super:

{
  mesa_noglu = (super.mesa_noglu.override {
    galliumDrivers = [ "virgl" "svga" "i915" "iris" "r300" "r600" "radeonsi" "nouveau" ];
  }).overrideAttrs (oldAttrs: {
    inherit (oldAttrs) pname;
    version = "19.1.0-devel";

    src = builtins.fetchGit {
      url = "https://gitlab.freedesktop.org/mesa/mesa.git";
      rev = "2bd08b8b9de9b10ecad5b808f56af2aa1bb8e007";
    };
  });
}

Done at #56261.

$dev/lib/pkgconfig/*.pc should be correct now. Though it affects libGL, so time to rebuild ~400 packages to test again.

Screwed up again, need to include /lib/dri back to the *.pc.

On the few weekends I spent recompiling my system, it more or less works fine, though I've ended up reverting due to abnormal CPU usage with compton using iris (don't know if it's been fixed since then).

Building this on my machine currently, we'll want to merge this into staging soon IMO because it seems that Mesa 19.1 will be the first release to remove the old build system, and require Meson.

Only 2 weeks left until the Mesa 19.1 release[1]. Any plans to merge into master/staging?

[1] https://www.mesa3d.org/release-calendar.html

Mesa 18 is very buggy with some vega cards and leads to GPU crashes while vulkan is enabled. I've got a temporary fix for myself (disable vulkan at build time), but I'd very much like this to be merged for everybody since upgrading mesa is the way better solution.

Needs rebase.

Mesa 19.1 has been released

Wow, thanks for the quick update! I did an equivalent local patch myself and can confirm that this seems to run just fine with my vega setup for both vulkan and opengl.

I've been rebasing this myself, but I've been using both Sway and GNOME with Mesa 19.1 and the updated libdrm without issue. I've even been using a tip build of Sway with Iris successfully.

It feels like time to get this and #56261 and #57773 into staging.

Is it possible to upgrade LLVM to version 8? I know that some LLVM 7.x.x versions has caused issues for DXVK (wine D3D to vulkan layer) and I've seen mesa 19 being paired well with LLVM 8. There is already an LLVM override for this package so one can simply change a single line in the all-packages.nix I think.

@GrahamcOfBorg eval

I hope it is okay, I rebased on staging.

@GrahamcOfBorg build mesa