Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-node-exporter: 0.17.0 -> 0.18.1; set version information #63763

Merged
merged 2 commits into from Aug 23, 2019
Merged

prometheus-node-exporter: 0.17.0 -> 0.18.1; set version information #63763

merged 2 commits into from Aug 23, 2019

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Package update.

Note there are breaking changes, documented in the upstream release notes.

The version information has more fields, which the push gateway sets fully:

nixpkgs/pkgs/servers/monitoring/prometheus/pushgateway.nix

Lines 22 to 26 in e478e6b

-X github.com/prometheus/pushgateway/vendor/github.com/prometheus/common/version.Version=${version}
-X github.com/prometheus/pushgateway/vendor/github.com/prometheus/common/version.Revision=${rev}
-X github.com/prometheus/pushgateway/vendor/github.com/prometheus/common/version.Branch=${rev}
-X github.com/prometheus/pushgateway/vendor/github.com/prometheus/common/version.BuildUser=${buildUser}
-X github.com/prometheus/pushgateway/vendor/github.com/prometheus/common/version.BuildDate=${buildDate}

I didn't think the dummy values contributed much, so omitted them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@globin
Copy link
Member

globin commented Aug 1, 2019 •
edited

@GrahamcOfBorg test prometheus-exporters.node

@globin globin merged commit c6a082b into NixOS:master Aug 23, 2019
@thefloweringash thefloweringash deleted the node-exporter-update branch August 23, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thefloweringash @globin