Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

munin: Use outPath for packages in makeFlags #63748

Merged
merged 1 commit into from Sep 16, 2019
Merged

munin: Use outPath for packages in makeFlags #63748

merged 1 commit into from Sep 16, 2019

Conversation

maljub01
Copy link
Contributor

@maljub01 maljub01 commented Jun 24, 2019 •
edited

Motivation for this change

With this change, evaluating the makeFlags attribute does not result in building the referenced packages.

This makes it possible for users to override buildInputs and remove inputs they don't want without having to also make a modified copy of the makeFlags attribute.

An example use case is to remove the jre dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maljub01
munin: Use outPath for packages in makeFlags
004737c 
With this change, evaluating the `makeFlags` attribute does not result in building the referenced packages.

This makes it possible for users to override `buildInputs` and remove inputs they don't want without having to also make a modified copy of the `makeFlags` attribute.

An example use case is to remove the `jre` dependency.
@maljub01
Copy link
Contributor Author

Hopefully this is a relatively minor change, but I'm happy to make any changes to this PR if it can help get it reviewed/merged sooner.

@maljub01
Copy link
Contributor Author

maljub01 commented Sep 15, 2019 •
edited

@bjornfor do you mind reviewing this as you seem to be the main reviewer for the munin package?

Thank you.

@bjornfor bjornfor merged commit d88f4ef into NixOS:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maljub01 @bjornfor