Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel-watcher: fix the build #63841

Merged
merged 2 commits into from Jun 27, 2019
Merged

bazel-watcher: fix the build #63841

merged 2 commits into from Jun 27, 2019

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Jun 27, 2019 •
edited

Motivation for this change

Bazel is currently broken on master, this PR fixes it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

closes #63838

@kalbasit kalbasit force-pushed the nixpkgs_63838_fix-bazel-watcher branch from 504d567 to 80d18bd Compare June 27, 2019 01:32
@kalbasit kalbasit force-pushed the nixpkgs_63838_fix-bazel-watcher branch from 80d18bd to f10f860 Compare June 27, 2019 01:57
@kalbasit
Copy link
Member Author

I tested this on NixOS and Darwin, and it works as expected.

@kalbasit kalbasit merged commit 02b8c32 into NixOS:master Jun 27, 2019
@kalbasit kalbasit deleted the nixpkgs_63838_fix-bazel-watcher branch June 27, 2019 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bazel-watcher is broken
1 participant
@kalbasit