Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackage.foxdot: init at 0.8.1 #63780

Merged
merged 1 commit into from Aug 22, 2019
Merged

pythonPackage.foxdot: init at 0.8.1 #63780

merged 1 commit into from Aug 22, 2019

Conversation

MrMebelMan
Copy link
Contributor

Motivation for this change

Just adding the package that I was badly missing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@MrMebelMan MrMebelMan requested a review from FRidh as a code owner June 25, 2019 19:27
@MrMebelMan
Copy link
Contributor Author

Added supercollider to propagatedBuildInputs, added a comment explaining why tests are disabled and fixed the license 🙏

@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

@GrahamcOfBorg build pythonPackages.foxdot python3Packages.foxdot

@mmahut mmahut changed the title foxdot: init at 0.7.30 pythonPackage.foxdot: init at 0.7.30 Aug 13, 2019
@MrMebelMan
Copy link
Contributor Author

Removed the conflicting maintainer commit & rebased master

@mmahut
Copy link
Member

mmahut commented Aug 22, 2019

@GrahamcOfBorg build pythonPackages.foxdot python3Packages.foxdot

@MrMebelMan MrMebelMan changed the title pythonPackage.foxdot: init at 0.7.30 pythonPackage.foxdot: init at 0.8.1 Aug 22, 2019
@mmahut
Copy link
Member

mmahut commented Aug 22, 2019

@GrahamcOfBorg build pythonPackages.foxdot python3Packages.foxdot

@mmahut mmahut merged commit a8122dc into NixOS:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrMebelMan @mmahut @Janik-Haag