Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1554204] [wpt PR 16997] - webrtc wpt: add addIceCandidate(new RTCIceCandidate({candidate, sdpMid})) test, a=testonly #17456

Closed
wants to merge 1 commit into from

Conversation

moz-wptsync-bot
Copy link
Collaborator

Automatic update from web-platform-tests
webrtc wpt: add addIceCandidate(new RTCIceCandidate({candidate, sdpMid})) test

which should have caught the bug

BUG=965483

Change-Id: I379f14ee625a9f43889d778b9774bb04949c73af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628722
Reviewed-by: Guido Urdaneta guidou@chromium.org
Commit-Queue: Philipp Hancke philipp.hancke@googlemail.com
Cr-Commit-Position: refs/heads/master@{#663512}

--

wp5At-commits: 740915b
wpt-pr: 16997

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1554204
gecko-commit: b6fd7a76dbfe2625ece58fede156c9628673c37e
gecko-integration-branch: central
gecko-reviewers: testonly

…{candidate, sdpMid})) test, a=testonly

Automatic update from web-platform-tests
webrtc wpt: add addIceCandidate(new RTCIceCandidate({candidate, sdpMid})) test

which should have caught the bug

BUG=965483

Change-Id: I379f14ee625a9f43889d778b9774bb04949c73af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628722
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#663512}

--

wp5At-commits: 740915b
wpt-pr: 16997

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1554204
gecko-commit: b6fd7a76dbfe2625ece58fede156c9628673c37e
gecko-integration-branch: central
gecko-reviewers: testonly
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@jgraham jgraham closed this Jul 10, 2019
@gsnedders gsnedders deleted the gecko/1554204 branch January 24, 2020 18:06
@gsnedders gsnedders restored the gecko/1554204 branch January 24, 2020 18:42
@foolip foolip deleted the gecko/1554204 branch April 14, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants