Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gnome3: enable networkmanagerapplet by default #63820

Closed
wants to merge 1 commit into from
Closed

nixos/gnome3: enable networkmanagerapplet by default #63820

wants to merge 1 commit into from

Conversation

bjornfor
Copy link
Contributor

Motivation for this change

networkmanagerapplet includes nm-connection-editor which is (apparently)
required to edit bluetooth network connections in gnome-shell /
gnome-control-center.

Fixes this:

.gnome-control-[5383]: Failed to launch nm-connection-editor: Failed to execute child process “nm-connection-editor” (No such file or directory)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bjornfor
nixos/gnome3: enable networkmanagerapplet by default
c4e7683 
networkmanagerapplet includes nm-connection-editor which is (apparently)
required to edit bluetooth network connections in gnome-shell /
gnome-control-center.

Fixes this:

.gnome-control-[5383]: Failed to launch nm-connection-editor: Failed to execute child process “nm-connection-editor” (No such file or directory)
@worldofpeace
Copy link
Contributor

nm-connection-editor is just an executable the application needs and it's preferred to just hardcode the path to the executable in the source code with a patch.

It seems we've done this. Perhaps we missed one.

@bjornfor
Copy link
Contributor Author

Good catch! I'll close this PR and open a new one where I update the gnome-control-panel patch instead.

@bjornfor bjornfor closed this Jun 26, 2019
@bjornfor
Copy link
Contributor Author

Hm, I don't find any unpatched "nm-connection-editor" strings in gnome-control-center. Must... look... closer...

@bjornfor
Copy link
Contributor Author

I couldn't find it because it's fixed in the master branch: f18aaa1.

@worldofpeace worldofpeace mentioned this pull request Jun 28, 2019
Merged
10 tasks
@bjornfor bjornfor deleted the nixos-networkmanagerapplet branch June 30, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bjornfor @worldofpeace