Thanks, commit messages are now fixed up.

Anything blocking this from getting merged now?

Version bumped to 1.1.6.

Version bumped to 1.1.7.

@georgyo Sorry this is taking so long to get in. It looks good to me except for that one pname thing. Could you fix that and we should be good to go?

@GrahamcOfBorg build ntpsec

Looks like it is failing the OfBorg build check on x86-64 too.

And nix-review pr 63821 on my system

builder for '/nix/store/qhrfzhwkgqzq969v7c7kbdidln8qmg9l-ntpsec-1.1.7.drv' failed with exit code 1; last 10 log lines:
  
  ../../ntpd/ntpd.c: In function 'parse_cmdline_opts':
  ../../ntpd/ntpd.c:334:4: warning: implicit declaration of function 'strlcpy'; did you mean 'strncpy'? [-Wimplicit-function-declaration]
    334 |    strlcpy(statsdir, ntp_optarg, sizeof(statsdir));
        |    ^~~~~~~
        |    strncpy
  
  Waf: Leaving directory `/build/ntpsec-1.1.7/build/main'

Interesting. I think this is failing to build with gcc9 which is now on master. I'll take a deeper look this weekend.

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unpriviledged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.