Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 19.03 with kexectools fixed [closes #56290] #63787

Closed
wants to merge 1 commit into from
Closed

Release 19.03 with kexectools fixed [closes #56290] #63787

wants to merge 1 commit into from

Conversation

dysinger
Copy link
Contributor

Motivation for this change

#56290

Things done

Compared master with release-19.03 when my armv7l-linux cross compilation failed on a aarch64 host.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer @dysinger
kexec-tools: use depsBuildBuild to get the right compiler
902f0b1 
Need this to avoid this issue in pkgsStatic:

  ld: cannot find -lc

/cc @Ericson2314
@dysinger dysinger changed the base branch from master to release-19.03 June 25, 2019 21:25
@dysinger dysinger closed this Jun 25, 2019
@dysinger dysinger deleted the release-19.03-with-kexectools-fixed branch June 25, 2019 21:30
@ttuegel ttuegel removed their request for review June 27, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais

@basvandijk basvandijk Awaiting requested review from basvandijk

@edolstra edolstra Awaiting requested review from edolstra

@edwtjo edwtjo Awaiting requested review from edwtjo

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

@joachifm joachifm Awaiting requested review from joachifm

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dysinger @matthewbauer