Skip to content

Release 19.03 with kexectools fixed [closes #56290] #63787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Release 19.03 with kexectools fixed [closes #56290] #63787

wants to merge 1 commit into from
+1 −1

Conversation

dysinger
Copy link
Contributor

Motivation for this change

#56290

Things done

Compared master with release-19.03 when my armv7l-linux cross compilation failed on a aarch64 host.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@matthewbauer @dysinger
kexec-tools: use depsBuildBuild to get the right compiler

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas
GPG key ID: 4C4BEFD7B18DC5E8
Expired
Verified
Learn about vigilant mode
902f0b1 
Need this to avoid this issue in pkgsStatic:

  ld: cannot find -lc

/cc @Ericson2314
@dysinger dysinger changed the base branch from master to release-19.03 June 25, 2019 21:25
@ofborg ofborg bot added 6.topic: emacs Text editor 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment labels Jun 25, 2019
@ofborg ofborg bot added 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Jun 25, 2019
@dysinger dysinger closed this Jun 25, 2019
@dysinger dysinger deleted the release-19.03-with-kexectools-fixed branch June 25, 2019 21:30
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ and removed 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: emacs Text editor 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: vim 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Jun 25, 2019
@ttuegel ttuegel removed their request for review June 27, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais

@basvandijk basvandijk

@edolstra edolstra

@edwtjo edwtjo

@Ericson2314 Ericson2314

@FRidh FRidh

@infinisil infinisil

@joachifm joachifm

@matthewbauer matthewbauer

@nbp nbp

@Profpatsch Profpatsch

@thoughtpolice thoughtpolice

@zimbatm zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dysinger @matthewbauer