Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql: drop support for deprecated package & module option #63786

Merged
merged 2 commits into from Jun 27, 2019
Merged

mysql: drop support for deprecated package & module option #63786

merged 2 commits into from Jun 27, 2019

Conversation

aanderse
Copy link
Member

Motivation for this change
  • According to https://en.wikipedia.org/wiki/MySQL#Release_history MySQL 5.5 is past end of life so we shouldn't ship it anymore.
  • The services.mysql.rootPassword option was never a good idea as it stores a password in the nix store. I'm straight up removing the option, as opposed to marking as deprecated, because this option completely breaks services.mysql.ensureUsers and services.mysql.ensureDatabases, which many NixOS services use now.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ping @Izorkin @dasJ @dermetfan @thefloweringash @orivej

@Izorkin
Copy link
Contributor

Izorkin commented Jun 25, 2019

@aanderse can not delete mysql55 ? I use for one site, with mysql57 not worked.

@flokli
Copy link
Contributor

flokli commented Jun 25, 2019

@Izorkin We shouldn't keep around EOL MySQL versions in nixpkgs.

You should try to get that application working with more recent MySQL versions, and if that's absolutely not possible, you can pin an older version of nixpkgs for your specific usecase.

@flokli
Copy link
Contributor

flokli commented Jun 25, 2019

@GrahamcOfBorg build unixODBCDrivers.mysql
@GrahamcOfBorg test mysql mysqlbackup

@aanderse aanderse mentioned this pull request Jun 26, 2019
Merged
10 tasks
@aanderse aanderse merged commit ae02678 into NixOS:master Jun 27, 2019
@aanderse aanderse deleted the mysql branch June 27, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@fpletz fpletz fpletz approved these changes

@peterhoeg peterhoeg peterhoeg approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@samueldr samueldr Awaiting requested review from samueldr

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aanderse @Izorkin @flokli @fpletz @peterhoeg