Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

franz: use wrapGAppsHook #63761

Merged
merged 1 commit into from Jul 4, 2019
Merged

franz: use wrapGAppsHook #63761

merged 1 commit into from Jul 4, 2019

Conversation

contrun
Copy link
Contributor

@contrun contrun commented Jun 25, 2019

I encountered crashes while opening the file selection dialog.

(franz:11597): GLib-GIO-ERROR **: 14:08:20.102: No GSettings schemas are installed on the system
[1]    11597 trace trap  franz

This error is also presented in various other gtk applications (e.g. #45286). I used the same trick to fix this error.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@contrun
franz: use wrapGAppsHook
5fff5ef 
I encountered crashes while opening the file selection dialog.

```
(franz:11597): GLib-GIO-ERROR **: 14:08:20.102: No GSettings schemas are installed on the system
[1]    11597 trace trap  franz
```

This error is also presented in various other gtk applications (e.g. NixOS#45286). I used the same trick to fix this error.
@worldofpeace worldofpeace merged commit 5e30ad6 into NixOS:master Jul 4, 2019
@worldofpeace
Copy link
Contributor

Sorry it took so long to merge this. Thanks for fixing this @contrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@contrun @worldofpeace @Mic92