Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurationLimit to systemd-boot to prevent running out of disk… #63766

Merged
merged 1 commit into from Jul 26, 2019
Merged

Add configurationLimit to systemd-boot to prevent running out of disk… #63766

merged 1 commit into from Jul 26, 2019

Conversation

domenkozar
Copy link
Member

@domenkozar domenkozar commented Jun 25, 2019 •
edited

Backports 224a656 with backwards compatible default.

I'd like to backport this as this is blocking me using stable, as my /boot runs out of disk space.

The tricky bit of python is:

>>> list(range(0, 10))
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
>>> list(range(0, 10)[-0:])
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
>>> list(range(0, 10)[-9:])
[1, 2, 3, 4, 5, 6, 7, 8, 9]

@domenkozar domenkozar mentioned this pull request Jun 25, 2019
Open
@domenkozar domenkozar added the 8.has: port to stable A PR already has a backport to the stable release. label Jun 25, 2019
@domenkozar domenkozar assigned lheckemann and unassigned lheckemann Jun 25, 2019
@domenkozar
Copy link
Member Author

@GrahamcOfBorg test installer

@domenkozar domenkozar force-pushed the backport-systemd-boot-configurationLimit branch from 64e4b13 to 64beed5 Compare June 25, 2019 12:25
@domenkozar
Add configurationLimit to systemd-boot to prevent running out of disk…
17be62f 
… space

Refs #23926

(cherry picked from commit 224a656)
Signed-off-by: Domen Kožar <domen@dev.si>
@domenkozar domenkozar force-pushed the backport-systemd-boot-configurationLimit branch from 64beed5 to 17be62f Compare June 25, 2019 13:16
@domenkozar
Copy link
Member Author

@GrahamcOfBorg test installer

@arianvp
Copy link
Member

arianvp commented Jun 30, 2019

Looks good to me. Thanks for this; I run into this one very often :)

@infinisil
Copy link
Member

The null change should also be (fore-?)ported to master

@domenkozar
Copy link
Member Author

Pushed in cfd507d

@domenkozar
Copy link
Member Author

Going to wait a couple of days and then merge this one.

@domenkozar domenkozar merged commit 760e770 into release-19.03 Jul 26, 2019
@lheckemann lheckemann deleted the backport-systemd-boot-configurationLimit branch July 29, 2019 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

@grahamc grahamc Awaiting requested review from grahamc

@lheckemann lheckemann Awaiting requested review from lheckemann

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@domenkozar @arianvp @infinisil @grahamc @bjornfor @lheckemann @edolstra