Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vapoursynth: wrap vspipe #63791

Merged
merged 1 commit into from Jul 4, 2019
Merged

vapoursynth: wrap vspipe #63791

merged 1 commit into from Jul 4, 2019

Conversation

tadeokondrak
Copy link
Member

Motivation for this change

See #58859 (vspipe included with VapourSynth doesn't work), but less complex and hopefully merged faster.

Apparently you don't even need to make it a python module for it to be usable, as nix-shell -p python3 vapoursynth seems to work fine. (I think it didn't when I made the first PR, but I may be wrong)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This was referenced Jun 26, 2019
Merged
Closed
rnhmjoj
rnhmjoj approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally vspipe works, thank you!

@teto
Copy link
Member

teto commented Jul 4, 2019

could you rebase/fix conflict and test please

@tadeokondrak
Copy link
Member Author

tadeokondrak commented Jul 4, 2019 •
edited

@teto done (currently testing) works!

@teto
Copy link
Member

teto commented Jul 4, 2019

Is the vapoursynth.withPlugins function still in question ? seems like the approach #64158 would be better in the long run. I guess it depends on how many plugins are available etc.
I am ok to merge this meanwhile, just wondering .

@tadeokondrak
Copy link
Member Author

tadeokondrak commented Jul 4, 2019 •
edited

Yes, I definitely plan to work more on this, see https://github.com/tadeokondrak/vs-overlay for my current progress on packaging plugins themselves, which I eventually would like to upstream (most) of into nixpkgs and add a withPlugins function. (although wrapping it as it in this PR is necessary either way)

@teto
Copy link
Member

teto commented Jul 4, 2019

rnhmjoj on irc tested and liked it.

@teto teto merged commit 983e56b into NixOS:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tadeokondrak @teto @rnhmjoj