Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/gdm: add autoSuspend option #63790

Merged
merged 1 commit into from Aug 6, 2019

Conversation

chpatrick
Copy link
Contributor

@chpatrick chpatrick commented Jun 25, 2019

Motivation for this change

Since GNOME 3.28 GDM auto-suspends after 20 minutes. This is a problem if you just want to turn on your computer so you can SSH into it later.

Things done

This commit adds an option to gdm that lets you turn this off. I think the previous dconf profile was invalid since DCONF_PROFILE=/etc/dconf/profile/gdm dconf dump complained.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Jun 26, 2019

This fixes #57616 and #42053

@jtojnar
Copy link
Contributor

jtojnar commented Jun 26, 2019

Also related #54150

@chpatrick
Copy link
Contributor Author

Can this be merged? :)

@jtojnar jtojnar added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jun 29, 2019
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me but I did not test it.

Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I did not test it either, though. I gave up on gdm a while ago because I had so much trouble.

@worldofpeace worldofpeace changed the title gdm: add autoSuspend option nixos/gdm: add autoSuspend option Jun 30, 2019
@worldofpeace
Copy link
Contributor

Testing this today 👍

@ofborg ofborg bot removed the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jul 1, 2019
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, build a system and /etc/dconf/profiles/gdm is the expected contents
and did a dconf dump for the profile and it has the expected settings set.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/problem-with-xkboptions-it-doesnt-seem-to-take-effect/5269/12

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/setting-caps-lock-as-ctrl-not-working/11952/5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants