Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vlang: init at 0.1.16 #63738

Merged
merged 1 commit into from Jul 29, 2019
Merged

vlang: init at 0.1.16 #63738

merged 1 commit into from Jul 29, 2019

Conversation

Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Jun 24, 2019

Motivation for this change

V is an interesting new language, might as well have a package for it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it and could successfully run the tetris example in a nix-shell with freetype curl glfw. Because of vlang/v#542 I also had to copy the font to my working directory.

pkgs/development/compilers/v/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/v/default.nix Outdated Show resolved Hide resolved
@JohnAZoidberg
Copy link
Member

If it takes them a long time to figure out vlang/v#457, maybe we could solve it with a wrapper, at least for the standard library.

@Chiiruno
Copy link
Contributor Author

This changed quick.
vlang/v@5a469c2
Gonna see what I can do.

@Chiiruno
Copy link
Contributor Author

Waiting until the releases page and v.c is updated, don't want to flip flop between revision and release revision if possible.

@srhb srhb added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Jun 25, 2019
pkgs/development/compilers/v/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/v/default.nix Outdated Show resolved Hide resolved
@vcunat
Copy link
Member

vcunat commented Jun 25, 2019

A bit meta-question: isn't "v" a bit too short/generic identifier? In particular, it seems that a couple distros use it already for a different project: https://github.com/rupa/v

@Chiiruno
Copy link
Contributor Author

Since V is a language, changing it to vlang should be fine IMO.

@vcunat
Copy link
Member

vcunat commented Jun 25, 2019

👍 That choice is also supported by them using https://github.com/vlang.

@Chiiruno
Copy link
Contributor Author

Get this problem with the bootstrapped V compiler, tested locally and it doesn't happen, will make issue both here and on the V repo, not sure which is at fault.

Looks like you are running V for the first time.
Setting VROOT to "/build/source".
time__ticks
0
pass=2 fn=`time__ticks`
panic: time_lin.v:9
undefined: `double`

@Chiiruno
Copy link
Contributor Author

Not a nix issue, 0.1.4 should be the version that finally gets merged.

@Chiiruno
Copy link
Contributor Author

Okay, things should be stable enough in this aspect for merge now.

@Chiiruno
Copy link
Contributor Author

Oh whoops, forgot to change it to vlang instead of v, one sec.

@Chiiruno Chiiruno changed the title v: init at 0.1.0 vlang: init at 0.1.4 Jun 26, 2019
@Chiiruno
Copy link
Contributor Author

Double checked; Ready.

@Chiiruno
Copy link
Contributor Author

Like this?

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually indent our files with 2 spaces everywhere. This uses 3.

pkgs/development/compilers/vlang/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/vlang/default.nix Outdated Show resolved Hide resolved
@Chiiruno
Copy link
Contributor Author

Not sure how my tabs got messed up, but it's fixed now.

@Chiiruno Chiiruno changed the title vlang: init at 0.1.5 vlang: init at 0.1.6 Jun 27, 2019
@Chiiruno
Copy link
Contributor Author

@srhb The "wait for upstream" tag is no longer needed, could you remove it please?

@veprbl veprbl removed the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Jun 27, 2019
@Chiiruno Chiiruno changed the title vlang: init at 0.1.6 vlang: init at 0.1.7 Jun 28, 2019
@Chiiruno Chiiruno changed the title vlang: init at 0.1.7 vlang: init at 0.1.10 Jun 30, 2019
@Chiiruno
Copy link
Contributor Author

Executable says 0.1.9 when executed, but the release is 0.1.10, maybe a release issue.

@chreekat
Copy link
Contributor

chreekat commented Jul 8, 2019

@Chiiruno , Sounds like another wait-for-upstream issue then?

@JohnAZoidberg
Copy link
Member

Upstream is really fast and they're already at v0.1.12.

@Chiiruno Chiiruno changed the title vlang: init at 0.1.10 vlang: init at 0.1.12 Jul 8, 2019
@Chiiruno
Copy link
Contributor Author

Chiiruno commented Jul 8, 2019

Looks fine to me now.

@veprbl
Copy link
Member

veprbl commented Jul 8, 2019

@GrahamcOfBorg eval

@veprbl
Copy link
Member

veprbl commented Jul 9, 2019

@GrahamcOfBorg build vlang

@veprbl
Copy link
Member

veprbl commented Jul 9, 2019

@Chiiruno
I could not make this work:

[nix-shell:~/.cache/nix-review/pr-63738]$ cp /nix/store/xz93v8lxlsjqak6r17c8qh7p2cbp07gx-vlang-0.1.12/share/examples/hello_world.v .

[nix-shell:~/.cache/nix-review/pr-63738]$ v hello_world.v 
Looks like you are running V for the first time.
V repo not found. Go to https://vlang.io to download V.zip 
or install V from source.

@Chiiruno
Copy link
Contributor Author

To fix that, either we would need to trick the V compilation process into thinking it was compiled at the nix store directory, or have a way to set the V repo directory to the nix store directory.

@Chiiruno
Copy link
Contributor Author

This may be fixed on the next update, with vlib being moved into /usr/lib.

@Chiiruno Chiiruno changed the title vlang: init at 0.1.12 vlang: init at 0.1.15 Jul 17, 2019
@Chiiruno
Copy link
Contributor Author

Should be ready.

@Chiiruno Chiiruno changed the title vlang: init at 0.1.15 vlang: init at 0.1.16 Jul 24, 2019
@veprbl
Copy link
Member

veprbl commented Jul 25, 2019

@GrahamcOfBorg build vlang

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work at least on darwin

@veprbl veprbl merged commit aaf2ecd into NixOS:master Jul 29, 2019
@Chiiruno Chiiruno deleted the dev/v branch July 30, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants