Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plata-theme: 0.8.3 -> 0.8.6 #63739

Closed
wants to merge 1 commit into from
Closed

Conversation

tadfisher
Copy link
Contributor

@tadfisher tadfisher commented Jun 24, 2019

Motivation for this change

Update plata-theme to 0.8.6.

Reintroduce the mateSupport option, which requires mate.marco and gtk3 for building. This defaults to true to mirror the upstream defaults.

Replace gnome2.glib argument with glib to fix evaluation when allowAliases = false, letting r-ryantm update the package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

]
++ stdenv.lib.optionals mateSupport [ gtk3 marco ]
++ stdenv.lib.optional telegramSupport zip;

buildInputs = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does a package that just produces images and gresources containing images have buildInputs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure; this was copied from adapta-gtk-theme which this descends from. I assume the theme has a runtime dependency on gtk-engine-murrine (at least for gtk2), and it does specify such in its gtk-2.0 rc files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worldofpeace Is there anything I need to address here? This line isn't part of the PR.

@tadfisher tadfisher closed this Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants