Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installation-device.nix: explain sshd usage, don't include clone-config #63773

Merged
merged 4 commits into from Aug 31, 2019
Merged

installation-device.nix: explain sshd usage, don't include clone-config #63773

merged 4 commits into from Aug 31, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jun 25, 2019 •
edited

Motivation for this change

The configuration used to build an installation medium isn't really
suitable to be (re)used when building a real system.

For example, it enables automatic root login without a password on the
console, installs sshd, but prevents it from starting on boot.

This can be very misleading when users try to derive their real system
from it - they should use nixos-generate-config instead, as described in
the manual.

Also update the mingetty helpLine to describe the sshd setup.

Closes #63576
Closes #26776

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested a review from samueldr June 25, 2019 14:24
@flokli
Copy link
Contributor Author

flokli commented Jun 25, 2019

@GrahamcOfBorg test installer

@samueldr

This comment has been minimized.

Sign in to view
@flokli flokli mentioned this pull request Jun 29, 2019
Closed
@flokli flokli mentioned this pull request Aug 17, 2019
Merged
10 tasks
@worldofpeace
Copy link
Contributor

Oh, missed the profiles documentation because I don't think I noticed when this was added.

@flokli flokli force-pushed the installation-device-fixes branch 2 times, most recently from 5669c04 to cfb4a12 Compare August 18, 2019 00:09
worldofpeace
worldofpeace approved these changes Aug 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs seem good 👍

@flokli
Copy link
Contributor Author

flokli commented Aug 18, 2019

@samueldr, could you give this a try once sd_image builds again?

@worldofpeace
Copy link
Contributor

Probably immediately easy enough to revert #63835 for the image

@flokli
nixos/installation-device.nix: explain sshd usage
f71fd79
@flokli
sd-image.nix: set installer.cloneConfig to false
0aa5e31 
As SD Card images are both installation media and installation target,
don't copy over a /etc/nixos/configuration.nix

Closes NixOS#63576.
@flokli
nixos/doc: update installation-device.nix
1515afe 
This got quite outdated. We now have both the nixos and root user
available for example.
@flokli
nixos/doc/clone-config.xml: add line about installation media = insta…
d6eb5b0 
…llation target
@flokli
Copy link
Contributor Author

flokli commented Aug 19, 2019

Rebased on top of master, as #66850 landed.

@flokli flokli merged commit 4e586de into NixOS:master Aug 31, 2019
@flokli flokli deleted the installation-device-fixes branch August 31, 2019 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr requested changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sd-image-aarch64 shouldn't import profiles/installation-device.nix SSHD doesn't work.
3 participants
@flokli @samueldr @worldofpeace