Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lesspass-cli: init at 9.0.0 #63753

Merged
merged 2 commits into from Aug 22, 2019
Merged

lesspass-cli: init at 9.0.0 #63753

merged 2 commits into from Aug 22, 2019

Conversation

jasoncarr0
Copy link
Contributor

Motivation for this change

Adding LessPass CLI tool

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jasoncarr0 jasoncarr0 changed the title Add LessPass stateless package manager lesspass: init at 8.0.1 Jun 25, 2019
@risicle
Copy link
Contributor

risicle commented Jun 25, 2019

I managed to get the tests working - I've pushed a commit to my branch: https://github.com/risicle/nixpkgs/tree/ris-lesspass

I needed to pull the source from github as the tests aren't included in the pypi tarball.

@jasoncarr0
Copy link
Contributor Author

jasoncarr0 commented Jun 25, 2019 •
edited

Awesome work with the tests. Thanks. I was a bit worried about pulling in the github given the README, but you're right that it's fine on a release version.

I've merged them into this PR

worldofpeace
worldofpeace suggested changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself to the maintainers list in a separate commit like

maintainers: add jasoncarr

pkgs/tools/security/lesspass/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/lesspass/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/lesspass/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/lesspass/default.nix Outdated Show resolved Hide resolved
@jasoncarr0 jasoncarr0 changed the title lesspass: init at 8.0.1 lesspass: init at 9.0.0 Aug 22, 2019
@jasoncarr0
Copy link
Contributor Author

Sorry, I was traveling at the time this came in and missed it for a while.

@worldofpeace
Copy link
Contributor

Can you rename it to lesspass-cli?
Other than that this looks good.

@jasoncarr0
Copy link
Contributor Author

Okay, that should be good now

worldofpeace
worldofpeace approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@worldofpeace worldofpeace changed the title lesspass: init at 9.0.0 lesspass-cli: init at 9.0.0 Aug 22, 2019
@worldofpeace worldofpeace merged commit 1f3b789 into NixOS:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jasoncarr0 @risicle @worldofpeace